Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customizable articles count per sync #5147

Merged

Conversation

@michivi
Copy link
Contributor

commented Jul 27, 2019

Adds a new client setting representing the number of articles that will be fetched from the Wallabag server for each synchronization.

Previously, Wallabag only returns 30 articles at a time by default. With this setting, koreader will be able to download a custom number of articles from the Wallabag server for each synchronization.

If the setting was not present in the user settings, the default value (30) will be used.

@Frenzie
Copy link
Member

left a comment

Thanks! A few nits. Also pinging @y-muller

plugins/wallabag.koplugin/main.lua Show resolved Hide resolved
plugins/wallabag.koplugin/main.lua Outdated Show resolved Hide resolved
plugins/wallabag.koplugin/main.lua Outdated Show resolved Hide resolved
plugins/wallabag.koplugin/main.lua Outdated Show resolved Hide resolved
plugins/wallabag.koplugin/main.lua Show resolved Hide resolved

@michivi michivi force-pushed the michivi:feat/customizable-articles-per-sync branch 3 times, most recently from 0db6e49 to bc6b2b6 Jul 27, 2019

fields = {
{
text = self.articles_per_sync,
description = T(_("Number of articles")),

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 28, 2019

Member

Btw, the description and the hint needn't be the same.

Anyway, you're not using the template function here.

Suggested change
description = T(_("Number of articles")),
description = _("Number of articles"),

This comment has been minimized.

Copy link
@michivi

michivi Jul 28, 2019

Author Contributor

Right, thanks!

I also added a validation test to prevent crashes on incorrect values.

@Frenzie Frenzie added this to the 2019.08 milestone Jul 28, 2019

@Frenzie Frenzie added the Plugin label Jul 28, 2019

Michivi
feat: customizable articles count per sync
Includes:
- New client settings menu and dialog.
- Articles count to fetch per sync is customizable.

@michivi michivi force-pushed the michivi:feat/customizable-articles-per-sync branch from bc6b2b6 to cbc29ed Jul 28, 2019

@Frenzie Frenzie merged commit 14bdf47 into koreader:master Jul 28, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.