Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallabag): archiving instead of deleting articles #5148

Merged
merged 1 commit into from Jul 28, 2019

Conversation

@michivi
Copy link
Contributor

commented Jul 28, 2019

Adds the option to remotely archive finished Wallabag articles instead of permanently deleting them.

Previous versions permanently deleted the remote finished articles. This behavior is preserved by default. If the archiving setting is used, then the finished articles won't be deleted but remotely archived.

The setting is available in the Settings menu as Archive instead of delete articles.

Perhaps it would be better (if possible) to regroup all the deletion options in a settings dialog? Also, all the options regarding deletion and archiving might get confusing to the user. I thought about rewriting the labels but how would that impact translation?

@@ -178,6 +182,14 @@ function Wallabag:addToMainMenu(menu_items)
self:saveSettings()
end,
},
{
text = _("Archive instead of delete articles"),

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 28, 2019

Member

Is that "mark as read"? Because if so, I think something like mark as read instead of deleting would be clearer.

Suggested change
text = _("Archive instead of delete articles"),
text = _("Archive instead of deleting"),

This comment has been minimized.

Copy link
@michivi

michivi Jul 28, 2019

Author Contributor

Yes, it is. You're right, it is essentially the Mark as read functionality. It seems to be called archived in the Wallabag API.

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 28, 2019

Member

It's just not a term I'm familiar with from the Wallabag website, and if I saw it in the API docs I forgot. :-)

Michivi
feat: archiving instead of deleting articles
Marks finished articles as read (archived) instead of permanently deleting them.

@michivi michivi force-pushed the michivi:feat/wallabag-archive-articles branch from ed81709 to 401e14e Jul 28, 2019

@Frenzie Frenzie added this to the 2019.08 milestone Jul 28, 2019

@Frenzie Frenzie added the Plugin label Jul 28, 2019

@Frenzie Frenzie merged commit 6cf9b4c into koreader:master Jul 28, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.