Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical edge gesture #5156

Merged
merged 6 commits into from Aug 1, 2019

Conversation

@robert00s
Copy link
Contributor

commented Jul 31, 2019

  • Add left/right edge swipe gesture
  • Move kobolight plugin to ReaderFrontlight
  • Remove kobolight plugin
  • New gestures - increase/decrease frontlight, increase/decrease frontlight warmth
  • Supports frontlight (warmth) change in file manger mode
  • Remove Frontlight gesture controller menu from Taps and Gestures

Defalut left edge swipe -> frontlight increase/dicrease (if present)
Default right edge swipe -> frontlight warmth increase/decresase (if present) - needs to be tested (I don't have device that supports this function)

Ref: #4240 (comment)

obraz

obraz

obraz

robert00s added some commits Jul 31, 2019

Add vertical edge gesture
* Add left/right edge swipe gesture
* Move kobolight plugin to ReaderFrontlight
* Remove kobolight plugin

@Frenzie Frenzie added this to the 2019.08 milestone Jul 31, 2019

@Frenzie Frenzie added the UX label Jul 31, 2019

@Frenzie
Copy link
Member

left a comment

If you rebase on top of master the unit tests should run correctly, see #5157. (Not sure if they cover any of the code you changed though.)

local powerd = Device:getPowerDevice()
local new_text
if powerd.is_fl_on then
new_text = _("Frontlight is on.")

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 31, 2019

Member

Or maybe Frontlight enabled/disabled?

This comment has been minimized.

Copy link
@robert00s

robert00s Aug 1, 2019

Author Contributor

Done :)

frontend/apps/reader/modules/readerfrontlight.lua Outdated Show resolved Hide resolved
frontend/apps/reader/modules/readergesture.lua Outdated Show resolved Hide resolved

robert00s and others added some commits Aug 1, 2019

Update frontend/apps/reader/modules/readerfrontlight.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@NiLuJe Do you have a device with natural light at your disposal to check btw?

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Alright, could you test & merge? :-)

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Appears to behave :) 👍

@NiLuJe NiLuJe merged commit c6c8c5a into koreader:master Aug 1, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@robert00s robert00s deleted the robert00s:gesture_swipe_ver branch Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.