Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: add an option to ignore volume keys or use them to turn pages #5158

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@pazos
Copy link
Contributor

commented Jul 31, 2019

Related to #5136

Requires koreader/koreader-base#938
Requires koreader/android-luajit-launcher#162

Fixes #1760
Fixes #3374

@pazos pazos requested a review from Frenzie Jul 31, 2019

@Frenzie Frenzie added the Android label Jul 31, 2019

@Frenzie Frenzie added this to the 2019.08 milestone Jul 31, 2019

@Frenzie
Copy link
Member

left a comment

lgtm

@@ -175,6 +175,17 @@ if Device:isAndroid() then
-- screen timeout options, disabled if device needs wakelocks.
common_settings.screen_timeout = require("ui/elements/screen_android"):getTimeoutMenuTable()

-- volume key events
common_settings.android_volume_keys = {
text = _("Use volume keys to turn pages"),

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 31, 2019

Member

(Use) volume key page turning?

@pazos pazos force-pushed the pazos:android_key_events branch from 5c61e63 to d240d13 Aug 1, 2019

@pazos pazos force-pushed the pazos:android_key_events branch from d240d13 to 060fc0e Aug 1, 2019

@pazos

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@Frenzie: changed the name to "Volume key page turning". Please modify as you wish and merge it when ready!

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

That's good by me. You updated this PR with the recently merged base/luajit-launcher stuff?

@pazos

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

You updated this PR with the recently merged base/luajit-launcher stuff?

Yes!

@pazos pazos merged commit 91b2faa into koreader:master Aug 1, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.