Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Big or Go Home! #5163

Merged
merged 4 commits into from Aug 2, 2019

Conversation

@NiLuJe
Copy link
Member

commented Aug 1, 2019

Make the Home button fallback to sane values in case no custom home directory is set (re #5154 ).
And if we're already home, make it jump to the first page.

(The QuickStart Guide properly introduces the long-press as the way to set defaults, so I'm not too torn up about mostly getting rid of that bit of QoL cuteness that may actually mean people wouldn't remember that long-presses are awesome in KOReader).

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Pinging @pazos about the Android default.

On the one hand, I like that it shows people where we live so they can find the settings manually later, on the other hand, no-one in their right mind should actually use this as their Home :D.

/sdcard/Downloads might be better? Or /sdcard?

I don't actually remember where a brand new install sends us...

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@NiLuJe It goes to /sdcard.

arg = {file or "/sdcard"}

/sdcard/koreader is just the settings. Not much reason to go there normally.

@Frenzie Frenzie added this to the 2019.08 milestone Aug 1, 2019

@Frenzie Frenzie added the UX label Aug 1, 2019

Match the Android default startup directory
If only for consistency w/ other platforms

@NiLuJe NiLuJe merged commit affc0f4 into koreader:master Aug 2, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@pazos pazos referenced this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.