Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Rename 'Scroll Mode' to 'Continuous' #5169

Merged
merged 2 commits into from Aug 2, 2019

Conversation

@Frenzie
Copy link
Member

commented Aug 2, 2019

The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see #5166 (comment).

But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot.

Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-)

Before

After

Slightly more awkward alternatives

E.g., the wordier continuous mode or continuous display.

PS I quoted myself from here.

[lang] Rename 'Scroll Mode' to 'Continuous'
The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see <#5166 (comment)>.

> But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot.

Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-)

@Frenzie Frenzie added this to the 2019.08 milestone Aug 2, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

No alternate solution with names for each part of the toggle instead of on | off?
(Like scroll | page in cre, that I'm glad you didn't change :)
continuous | paged ?

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Good suggestion! So then it becomes something like:

Display: continuous | paged
View: continuous | paged

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

(Like scroll | page in cre, that I'm glad you didn't change :)

Also that's an accident. I didn't realize it was using different words for the same thing. ;-)

There it's View mode:
Screenshot_2019-08-02_21-23-53

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

I never minded the scroll mode name, but it seems to be a somewhat frequent misunderstanding that scroll mode implies scrolling. You can definitely understand why that might be — it's right there in the name after all! I believe some variation of continuous is used by Adobe Acrobat and Evince.

Screenshot_2019-08-02_21-42-31

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Fine with me.
continuous instead of scroll is clearer even for cre, except may be for newcomers to follow the code :)
(Adds a bit of unbalance to the buttons' texts' widths, the large continuous vs the small page.)
I don't really like "paged", but you kept "page" so I'm fine - but adjective | name feels ok?

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

It could also be per-page or something.

@Frenzie Frenzie merged commit ac15143 into koreader:master Aug 2, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:continuous branch Aug 2, 2019

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

paginated?

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

paginated?

I prefer the unbalance to that one :)

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Fair enough, both are fine with me ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.