Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default zoom mode & add warning message for fit page + scroll #5170

Merged
merged 7 commits into from Aug 5, 2019

Conversation

@Frenzie
Copy link
Member

commented Aug 2, 2019

The alternative is to disable scroll mode by default, but the default combination of fit page + scroll is a bit odd.

Fixes #5166.

Screenshot_2019-08-02_20-50-47

@Frenzie Frenzie added bug UX labels Aug 2, 2019

@Frenzie Frenzie added this to the 2019.08 milestone Aug 2, 2019

@Frenzie Frenzie force-pushed the Frenzie:zoomstuff branch from 1f759ba to f075b5d Aug 2, 2019

@Frenzie Frenzie force-pushed the Frenzie:zoomstuff branch from f075b5d to 9660835 Aug 2, 2019

@Frenzie Frenzie changed the title Change default zoom mode & add warning message for fit page + scroll [WIP] Change default zoom mode & add warning message for fit page + scroll Aug 3, 2019

Frenzie added some commits Aug 4, 2019

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2019

I figured a little warning message would be better than a full dialog for starters.

Screenshot_2019-08-04_10-32-12
Screenshot_2019-08-04_10-32-19

@Frenzie Frenzie changed the title [WIP] Change default zoom mode & add warning message for fit page + scroll Change default zoom mode & add warning message for fit page + scroll Aug 4, 2019

@Frenzie Frenzie merged commit ec6e34c into koreader:master Aug 5, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:zoomstuff branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.