Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Dict lookups: have them always interruptible #5173
They should be now interruptible when fuzzy search is disabled, and on Android.
Also increase the timeout when downloading Wikipedia HTML, needed when making an EPUB out of https://zh.wikipedia.org/wiki/%E4%B8%AD%E5%8D%8E%E4%BA%BA%E6%B0%91%E5%85%B1%E5%92%8C%E5%9B%BD).
Yes, it should, we do that correctly I think:
But we'll wait contiuously if it never terminates for some reason... (unlike Trapper:dismissableRunInSubprocess() where we send a kill before collecting it).
With this PR or without?
That was before this PR, yeah, but with the Trapperized variant (i.e., fuzzy match).
And it appeared to be "forever" (i.e., had to restart KOReader).
To be clear, when it broke, everything instantly returned an empty (no match) result.
Never saw that happen on a Kobo, but, then, I rarely have cause to cancel a lookup, ever.
So that was an extremely edge-casey behavior when testing the original report from MR: essentially doing a quick double-tap ASAP after the hold.