Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hold left corner doesn't work properly #5177

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@robert00s
Copy link
Contributor

commented Aug 3, 2019

Close: #5174
Hold gesture was eaten by a hidden return button.

-- return button
self.page_return_arrow = Button:new{
icon = "resources/icons/appbar.arrow.left.up.png",
callback = function()
if self.onReturn then self:onReturn() end
end,
bordersize = 0,
show_parent = self.show_parent,
readonly = self.return_arrow_propagation,

@Frenzie Frenzie added the bug label Aug 3, 2019

@Frenzie Frenzie added this to the 2019.08 milestone Aug 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 3, 2019

Codecov Report

Merging #5177 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5177   +/-   ##
=======================================
  Coverage   47.69%   47.69%           
=======================================
  Files         243      243           
  Lines       35375    35375           
=======================================
  Hits        16872    16872           
  Misses      18503    18503

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd29f6...fd55866. Read the comment docs.

@Frenzie Frenzie merged commit a10fc83 into koreader:master Aug 3, 2019

1 check was pending

ci/circleci Your tests are queued behind your running builds
Details

@robert00s robert00s deleted the robert00s:hold_bottom_left branch Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.