Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend edge zones #5181

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@robert00s
Copy link
Contributor

commented Aug 5, 2019

@Frenzie Frenzie added this to the 2019.08 milestone Aug 5, 2019

@Frenzie Frenzie added the UX label Aug 5, 2019

@Frenzie

Frenzie approved these changes Aug 5, 2019

Copy link
Member

left a comment

Pinging @poire-z

@@ -71,14 +71,14 @@ function ReaderFrontLight:onChangeFlIntensity(ges, direction)
local powerd = Device:getPowerDevice()
local gestureScale
if ges.direction == "south" or ges.direction == "north" then
gestureScale = Screen:getHeight() * 7/8 * 0.8
gestureScale = Screen:getHeight() * 0.8

This comment has been minimized.

Copy link
@poire-z

poire-z Aug 5, 2019

Contributor

Was that the reason for me feeling these last few days that swiping left did not change frontlight level as much as before ? :)

@poire-z

poire-z approved these changes Aug 5, 2019

Copy link
Contributor

left a comment

Thanks :)

@Frenzie Frenzie merged commit dac2458 into koreader:master Aug 5, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@robert00s robert00s deleted the robert00s:extend_edge_zones branch Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.