Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: conflict horizontal edge gesture with link swipe #5189

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@robert00s
Copy link
Contributor

commented Aug 8, 2019

See: #5186

Horizontal left edge gesture gets in conflict with the other left swipe. I have 'Swipe to follow nearest link' enabled, so every time there is a link on the page my bottom/top left edge swipe follows that link instead.

@robert00s robert00s requested a review from poire-z Aug 8, 2019

@Frenzie Frenzie added the UX label Aug 8, 2019

@Frenzie Frenzie added this to the 2019.08 milestone Aug 8, 2019

@poire-z
Copy link
Contributor

left a comment

Good for the migration to registerTouchZones, but it might need a bit more overrides.
(With the old ges_events, I think it was first registered/first served, and they were registered in the order readerui.lua registers the modules, and readerlink is one of the first, so it must have had a higher priority.)

@@ -953,6 +953,9 @@ function ReaderGesture:setupGesture(ges, action)
"paging_swipe",
"rolling_swipe",
}
overrides_horizontal_edge = {
"swipe_link"
}

This comment has been minimized.

Copy link
@poire-z

poire-z Aug 8, 2019

Contributor

Shouldn't it also overrides the ones that overrides_vertical_edge does?
And both overrides_vertical_edge and overrides_horizontal_edge might also need to override readerconfigmenu_swipe and readermenu_swipe (they may not overlap as DTAP_ZONE_MENU.x=1.8 in defaults.lua, but some people may increase that).

For info, some months ago (so it may no more be correct), I checked the various gestures overrides and possible conflicts in #4856 (comment).

This comment has been minimized.

Copy link
@robert00s

robert00s Aug 8, 2019

Author Contributor

Fully agree :)

ratio_x = 0, ratio_y = 0,
ratio_w = 1, ratio_h = 1,
},
handler = function(ges) return self:onSwipe(_, ges) end,

This comment has been minimized.

Copy link
@poire-z

poire-z Aug 8, 2019

Contributor

That new one might also need some override (paging_swipe, rolling_swipe...) I guess.

@poire-z

poire-z approved these changes Aug 8, 2019

@Frenzie Frenzie merged commit f450936 into koreader:master Aug 8, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.