Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parentheses #5198

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@jetomit
Copy link
Contributor

commented Aug 12, 2019

Prevents a crash when the WIFI_MODULE environment variable is not
defined.

Add missing parentheses
Prevents a crash when the WIFI_MODULE environment variable is not
defined.
@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Ooops. :D

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

For reference, what's the context for WIFI_MODULE being undefined in your instance?

@Frenzie Frenzie added the bug label Aug 12, 2019

@Frenzie Frenzie added this to the 2019.09 milestone Aug 12, 2019

@jetomit

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

For reference, what's the context for WIFI_MODULE being undefined in your instance?

I am running koreader in an Alpine rootfs without the original Kobo software, which normally sets this variable.

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

The crash being attempt to concatenate a nil value?

@jetomit

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Yes.

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

How are you dealing with the potential lack of other relevant env vars? (PRODUCT, PLATFORM, WIFI_MODULE_PATH, among others)?

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@NiLuJe To be fair, the line as written clearly implies a fallback in case of nil. ;-P

@jetomit

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

How are you dealing with the potential lack of other relevant env vars? (PRODUCT, PLATFORM, WIFI_MODULE_PATH, among others)?

I’m not, everything seems to just work. :) I have not managed to set up wireless yet due to some driver issues (not related to koreader), but I don’t use it anyway.

@Frenzie Frenzie added the Kobo label Aug 12, 2019

@Frenzie Frenzie merged commit 20493ee into koreader:master Aug 12, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@jetomit jetomit deleted the jetomit:fix-parens branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.