Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix after #5203 #5218

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@robert00s
Copy link
Contributor

commented Aug 17, 2019

@@ -565,7 +565,7 @@ function ReaderFooter:addToMainMenu(menu_items)
{
text = _("Alignment"),
enabled_func = function()
return self.settings.disable_progress_bar
return not self.settings.disable_progress_bar == false
end,

This comment has been minimized.

Copy link
@Frenzie

Frenzie Aug 17, 2019

Member

Maybe some parentheses for clarity?

This comment has been minimized.

Copy link
@poire-z

poire-z Aug 17, 2019

Contributor

Or just return self.settings.disable_progress_bar == true.
(our touchmenu code considers nil to mean: enabled - it just checks for false meaning: disabled)

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

Just in case you're not yet bored with the footer :)
As you show some sample in the menu item text for Progress percentage format, you could show it for more/all of them (most probably just useful for the Duration format, classic vs modern is a bit obscure - although one immediately sees what it means in the footer when updating...)

@robert00s

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

Now all settings have samples:

obraz

obraz

obraz

obraz

@Frenzie Frenzie merged commit f56e9bc into koreader:master Aug 17, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie added this to the 2019.09 milestone Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.