Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine and others, adds HTML extended debug view #5219

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@poire-z
Copy link
Contributor

commented Aug 17, 2019

Bump crengine koreader/crengine#305 :

  • View HTML: option to show text unicode codepoints
  • Fix attribute parsing: decode &-encoded chars
  • Text: allow wrap after more unicode spaces and hyphen (Closes #5191)
  • Fix: no left hanging when hanging punctuation disabled
  • lvtextfm.cpp: more comments, some formatting cleanup
  • Optimize background image drawing
  • CSS: fix background-image file path resolution

Bump harfbuzz to 2.6.0 koreader/koreader-base#917
Bump luasec to 0.8.1 koreader/koreader-base#949

cre.cpp: koreader/koreader-base#950
Adds setBackgroundImage() proxy function to crengine facility to set background textures (this is unrelated to the background-image CSS fixes).
No frontend code (yet) to select such an image (dunno if we should provide some free samples, let the user put his ones in styletweaks/ and build a menu for easy selection - or just use a a FileChooser).
For those interested to see, just add some of the tx_*.jpg files from https://github.com/koreader/crengine/tree/master/android/res/drawable in your koreader root directory, and add something like that:

--- a/frontend/apps/reader/modules/readertypeset.lua
+++ b/frontend/apps/reader/modules/readertypeset.lua
@@ -122,6 +122,7 @@ function ReaderTypeset:onReadSettings(config)
         self.nightmode_images = (global == nil or global == 1) and 1 or 0
     end
     self:toggleNightmodeImages(self.nightmode_images)
+    self.ui.document:setBackgroundImage("tx_old_book.jpg")
 end

 function ReaderTypeset:onSaveSettings()

image
(This is totaly unbearable on eInk - at least on my Kobo GloHD, which doesn't really like grey -, but it may be interesting on Android.)

View HTML: adds a 3rd view (extended debug view), showing the unicode codepoint of each char and crengine rendereing methods.
image
(might be only useful to me, but I need the first debug view without all that).

bump crengine, adds HTML extended debug view
Bump crengine: background image and other fixes:
- View HTML: option to show text unicode codepoints
- Fix attribute parsing: decode &-encoded chars
- Text: allow wrap after more unicode spaces and hyphen
- Fix: no left hanging when hanging punctuation disabled
- lvtextfm.cpp: more comments, some formatting cleanup
- Optimize background image drawing
- CSS: fix background-image file path resolution

Bump luasec to 0.8.1
Bump harfbuzz to 2.6.0

cre.cpp:
Adds setBackgroundImage() proxy function to crengine
facility to set background textures (this is unrelated
to the background-image CSS fixes).
No frontend code (yet) to select such an image.

View HTML: adds a 3rd view (extended debug view), showing the
unicode codepoint of each char and crengine rendereing methods.

@Frenzie Frenzie added this to the 2019.09 milestone Aug 17, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

(might be only useful to me, but I need the first debug view without all that).

Nah, I'll (very rarely) consider it useful not to have to open up a document on my computer for that. ;-)

@poire-z poire-z merged commit d25d449 into koreader:master Aug 17, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:bump_crengine branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.