Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Polish keyboard #5223

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@robert00s
Copy link
Contributor

commented Aug 18, 2019

After #4886 Polish keyboard is no more needed. Now we can use standard keyboard with popup selection.

obraz

@Frenzie Frenzie added this to the 2019.09 milestone Aug 18, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Yeah, it's not worthwhile to have a more Polish QWERTZ? See for example the French AZERTY layout which uses only a few minor modifications: https://github.com/koreader/koreader/blob/f56e9bcf981c68d91cb37e151b4a02cb70b389be/frontend/ui/data/keyboardlayouts/fr_keyboard.lua

@robert00s

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

But Polish standard is QWERTY :) QWERTZ is very rarely used (eg on old typewriters).

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Ah, excellent. shakes fist at AZERTY and QWERTZ

@Frenzie Frenzie added the UX label Aug 18, 2019

@Frenzie Frenzie merged commit c57bead into koreader:master Aug 18, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.