Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kindle support devices list #5235

Merged
merged 3 commits into from Aug 22, 2019

Conversation

@hwhung0111
Copy link
Contributor

commented Aug 21, 2019

No description provided.

@Frenzie Frenzie requested a review from NiLuJe Aug 21, 2019

@Frenzie Frenzie added the Kindle label Aug 21, 2019

@Frenzie Frenzie added this to the 2019.09 milestone Aug 21, 2019

@NiLuJe
Copy link
Member

left a comment

This is perfectly valid, but while you're there, mind updating KT to KT2 and KT2 to KT3 (KT is ambiguous, and generally avoided)?.

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Oh, and adding KT4 at the bottom, too ;).

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Oops, I meant KT4 at the bottom, my bad -_-".

Basically:

KT -> KT2
KT2 -> KT3

And what you just added -> KT4

@hwhung0111

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Oh, I see.

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@NiLuJe Was this good now?

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Oh, yes, my bad, it's fine, thanks for the ping, I missed the last update when I replied by mail :/.

@Frenzie Frenzie merged commit 73c8e5c into koreader:master Aug 22, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@hwhung0111 hwhung0111 deleted the hwhung0111:Update branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.