Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat, Kobo] Implement shutdown from suspend #5280

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@Frenzie
Copy link
Member

commented Aug 29, 2019

This allows to shutdown straight from suspend just like Nickel.

Fixes #2431.

[feat, Kobo] Implement shutdown from suspend
This allows to shutdown straight from suspend just like Nickel.

Fixes <#2431>.

@Frenzie Frenzie added this to the 2019.09 milestone Aug 29, 2019

@Frenzie Frenzie requested a review from NiLuJe Aug 29, 2019

@NiLuJe
NiLuJe approved these changes Aug 29, 2019
Copy link
Member

left a comment

LGTM at a glance ;).

I happen to highly dislike that kind of sneaky Power Button behavior, but that's just me ;).

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

I was about to close it as won't fix when I noticed Nickel does it that way. I'm not completely convinced it makes sense either, but it seems relatively harmless because who's going to accidentally press the button for 2 seconds? So then I wondered how hard it could be anyway, and 15 minutes later there was this PR. (It would've taken 2 minutes but restarting the device and all takes a lot of extra time.)

@Frenzie Frenzie merged commit cfa73be into koreader:master Aug 29, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:shutdown-from-suspend branch Aug 29, 2019

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

My thoughts exactly ;).

Frenzie added a commit to Frenzie/koreader that referenced this pull request Sep 1, 2019
Revert "[feat, Kobo] Implement shutdown from suspend (koreader#5280)"
This reverts commit cfa73be.

Cervantes and Sony secretly depend on hacky Kobo code.
Reported by @avsej, see <koreader#2431 (comment)>.

Closes <koreader#5292>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.