Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Implement fulltext search direction #5283

Merged
merged 3 commits into from Aug 30, 2019

Conversation

@Frenzie
Copy link
Member

commented Aug 30, 2019

Closes #5054.

Before / After

@Frenzie Frenzie added this to the 2019.09 milestone Aug 30, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Wouldn't backward | forward sound nicer than previous | next in this context (as there is no hit yet, that could have a previous or a next hit) ?

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Or just the same ⯈ type arrows as in the dictionary? I didn't really pay attention but the search is also grossly abusing < > there instead of something slightly nicer.

PS It's not that specific ⯈ character but a "white triangle" or something.

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Yep, those symbols would look fine there too :)

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Not quite there yet. It needs a different |-like character.

Screenshot_20190830_130543
Screenshot_20190830_130556

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

I think left/right one eighth block look pretty decent.

Screenshot_20190830_131325

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Kinda thick, but so are front and back covers :) so fine with me.

@Frenzie Frenzie merged commit f627027 into koreader:master Aug 30, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:search-direction branch Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.