Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fine tune buttons to horizontal margins #5303

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@robert00s
Copy link
Contributor

commented Sep 1, 2019

Similar to top and bottom margins I add fine tune buttons to L/R margins.

Before:

After:

@Frenzie Frenzie added this to the 2019.09 milestone Sep 1, 2019

@Frenzie Frenzie added the UX label Sep 1, 2019

@Frenzie
Frenzie approved these changes Sep 1, 2019
Copy link
Member

left a comment

Nice, I was just wondering about that the other day.

@poire-z
poire-z approved these changes Sep 1, 2019

@Frenzie Frenzie merged commit b038fa3 into koreader:master Sep 1, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Sep 2, 2019
Frenzie added a commit that referenced this pull request Sep 3, 2019
[fix] Allow setting a fine-tuned font size as default (#5306)
And a couple bugfix this unearthed:

* Always set the default as the *current* value, no matter what (by chance, this was not an issue for margins).
* Don't crash on the hold gesture in the -/+ buttons for the horizontal margins (regression since #5303).

@robert00s robert00s deleted the robert00s:h_margin branch Sep 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.