Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a fine-tuned font size as default #5306

Merged
merged 5 commits into from Sep 3, 2019

Conversation

@NiLuJe
Copy link
Member

commented Sep 2, 2019

And a couple bugfix this unearthed:

  • Always set the default as the current value, no matter what (by chance, this was not an issue for margins).
  • Don't crash on the hold gesture in the -/+ buttons for the horizontal margins (regression since #5303).
NiLuJe added 4 commits Sep 2, 2019
Better variable names
Makes the "actually use the current value, always" fix sneaked in the
first commit more obvious ;).
@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

I vaguely thought about making the font_size toggle thing more generic, but, AFAICT, this is the only thing in the code that's built this way, so, meh.

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

@Frenzie : Err, CircleCI went kablooey?

@robert00s

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Thanks for fix.

@Frenzie

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

@NiLuJe Oh, that sucks. :-/ It's not CircleCI exactly but your CircleCI. I added the ability to push to Transifex and the koreader-docs repo through hidden environment variables. So if you added a koreader-vars context, even if completely empty, it should work just fine.

context: koreader-vars

I wonder if that context thingy can somehow be optional… it's completely irrelevant except for the push to master. I could change the workflow but that'd be quite a bit of effort for essentially the same result. ;_; Also I'm not entirely sure if just because the job weren't reached it still wouldn't error on it.

@Frenzie

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

PS You can find that here, or in your own user/org settings for the repo anyway:

Screenshot_2019-09-02_17-36-30

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

@Frenzie: That did the trick, thanks!

@Frenzie Frenzie added this to the 2019.09 milestone Sep 2, 2019

@Frenzie Frenzie added the UX label Sep 2, 2019

self.config:onMakeDefault(self.name, self.name_text,
self.values or self.args, self.toggle, position)
if self.name == "font_fine_tune" then
--- @note Ugly hack for the only widget that uses a dual toggle for fine-tuning (others prefer a buttonprogress)

This comment has been minimized.

Copy link
@Frenzie

Frenzie Sep 2, 2019

Member

I also still have to make that fine-tuning thing work for EPUB/FB2 in MuPDF. :-P

@Frenzie Frenzie merged commit d66cf7a into koreader:master Sep 3, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Link to (presumably) the reason for this PR, for posterity: https://www.mobileread.com/forums/showthread.php?p=3884539#post3884539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.