Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cervantes]: launch QBookApp from KOReader #5316

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@pazos
Copy link
Contributor

commented Sep 4, 2019

Supersedes #5081

It was tested by @ZapperDJ in #5081 (comment)

@pazos pazos added this to the 2019.09 milestone Sep 4, 2019

@pazos pazos force-pushed the pazos:cervantes_back_to_home branch from b351863 to a276a65 Sep 4, 2019

@pazos

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Err, I think [ FAILED ] spec/front/unit/readhistory_spec.lua @ 363: ReadHistory module should not automatically remove deleted items from history if setting has been set to false has nothing to do with this pull 😟

@Frenzie

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Probably #3097. You can just restart the build in the once a month case it happens.

@Frenzie Frenzie merged commit cb2a3d9 into koreader:master Sep 4, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.