Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify battery meters look'n feel #5537

Merged
merged 15 commits into from Oct 27, 2019
Merged

Unify battery meters look'n feel #5537

merged 15 commits into from Oct 27, 2019

Conversation

@NiLuJe
Copy link
Member

NiLuJe commented Oct 26, 2019

We unfortunately lack a battery glyph, so we'll make do with the power
glyph instead.

A vertical lignting bolt suffix now always means charging.

Fix #5535

We unfortunately lack a battery glyph, so we'll make do with the power
glyph instead.

A vertical lignting bolt suffix now always means charging.

Fix #5535
@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Oct 26, 2019

batt_both

Includes a completely gratuitous use of instead of an em-dash because it had "electric" in the name and looked mildly cool ;p.

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Oct 26, 2019

In fact, I vaguely considered dropping the power icon from the topmenu and just keeping the electric arrow.

But we'd be back to square one re: footer & topmenu not matching.

(And using the electric arrow in the footer would probably look weird, as it's horizontal, and tiny).

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Oct 27, 2019

Okay, I really wasn't a huge fan of the power icon, so splurged for new icons (koreader/koreader-fonts#7).

batt_nerd

On the upside, we get a different icon every 10%, and a fixed-width icon even when charging.

(Search for battery over here to get a preview, which is pretty much what you'd expect ^^).

They already have enough whitespace on their own.
@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Oct 27, 2019

Post whitespace squish:

batt_nerd2

NiLuJe added 8 commits Oct 27, 2019
FreeFonts has a bunch of weird stuff in the Private Use Block...
koreader/koreader-fonts#7

Because we need the new symbols from nerdfonts ;).
Actual behavior probably ought to be revisited?
Bis
@Frenzie Frenzie added this to the 2019.11 milestone Oct 27, 2019
@Frenzie Frenzie added the UX label Oct 27, 2019
Copy link
Member

Frenzie left a comment

Sounds good.

@NiLuJe NiLuJe merged commit 8d28164 into koreader:master Oct 27, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@Biep

This comment has been minimized.

Copy link

Biep commented Oct 27, 2019

Looks good too!

NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 27, 2019
NiLuJe added a commit that referenced this pull request Oct 27, 2019
* Restore '+' prefix when charging in the footer w/ letters prefixes

Regression since #5537

* Don't use a full battery icon in the menu entry

Make it clear that one isn't in-sync with the current gauge
@ptrm

This comment has been minimized.

Copy link

ptrm commented Oct 28, 2019

That looks great. Any chance for no-percentage-just-icon option for battery ;) ?

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Oct 30, 2019

Well, I'm sorry to always be the one to come up with that kind of comment, but I don't like that big black battery icon in the footer :|
I just had a chance to test in on my Android phone (I'll probably patch it out on my Kobo), and the 100% battery icon is just too big and solid black that it catches/attract my eye when reading (there's this black insect at the bottom among the usual grey-like footer text and other icons that I can't help noticing - I'll baptize that effect: Peripheral vision pollution :).
It's less bothering when the battery is at 20% when it's less black :) (it should be the other way around: don't catch my eye when 100% but catch it when i'm reaching 20% and I need to charge it :)

@robert00s

This comment has been minimized.

Copy link
Contributor

robert00s commented Oct 30, 2019

Well, I'm sorry to always be the one to come up with that kind of comment, but I don't like that big black battery icon in the footer :|

I have the same opinion.

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Oct 30, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Oct 31, 2019

feel free to add an option to enforce the outline icon in the footer ;).

[x] Ditch that ridiculously big solid black battery icon ? That's an accurate wording, but a bit too long I'm afraid :)
(I really think it's a bad icon/design - and as distracting as the white Kobo logo at the bottom of the Kobo Clara, vs the black on black Kobo logo on the GloHD. Yes, people could/would get used to it, but that's just imposing uneeded fancyness vs leanness.)

Anyway, if people really like/want it, it probably shouldn't just be an option for that icon, but may be 2 icons sets (and I'd rather not even have that tall outline battery icon, but something a bit smaller).
So, we might want to think about other "animated/dynamic" icons if we want to propose 2 icons set: a lean one, and a more fancy/dynamic one.

Btw, if your unicode codepoints for the various battery level symbols are consecutive, you might want to swap your 2 long if/else branches for something like:

-- Use number in solid black circle symbol (U+2776...277F)
local symbol = util.unicodeCodepointToUtf8(10101 + (j < 10 and j or 10))

@Biep

This comment has been minimized.

Copy link

Biep commented Oct 31, 2019

This is going towards themes: people could choose a set of characters (be they initials, emojis, or whatever) to show the various menu and status bar options. It would just be a variable string, indexed by the code that created the UI elements.

I hate those ridiculous three horizontal lines! I want to see a true hamburger - with cheese!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.