Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: touchscreen toggle #5564

Merged
merged 1 commit into from Nov 5, 2019
Merged

android: touchscreen toggle #5564

merged 1 commit into from Nov 5, 2019

Conversation

@pazos
Copy link
Contributor

pazos commented Nov 2, 2019

Using camera button.

Fixes #5558

@pazos pazos added this to the 2019.11 milestone Nov 2, 2019
@pazos pazos requested a review from poire-z Nov 2, 2019
@poire-z
poire-z approved these changes Nov 2, 2019
Copy link
Contributor

poire-z left a comment

Looks fine to me (just some cosmetic code comments).

frontend/ui/elements/common_settings_menu_table.lua Outdated Show resolved Hide resolved
frontend/ui/elements/common_settings_menu_table.lua Outdated Show resolved Hide resolved
@@ -220,6 +220,16 @@ if Device:isAndroid() then
end,
}

-- camera key events
common_settings.android_camera_keys = {
text = _("Camera key toggles touchscreen"),

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 2, 2019

Member

Maybe something like this?

Camera key toggles ignore mode

This comment has been minimized.

Copy link
@pazos

pazos Nov 2, 2019

Author Contributor

Since I'm not native I'm fine with something that means: "(usar la) tecla de cámara (para) conmuta(r) el panel táctil". The easy translation for that is: camera key switches/toggles touchscreen but if you find your suggestion a better translation then is good for me 😄

This comment has been minimized.

Copy link
@poire-z

poire-z Nov 2, 2019

Contributor

I find "ignore mode" a bit obscure (what is ignored? history, statistics, page turns, taps, swipes, other keys?) - and it's not all user interactions that are ignored: volume keys to turn pages would still work while touchscreen is disabled.
"toggles touchscreen activation" ?

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 2, 2019

Member

Touch ignore mode (camera button)?

This comment has been minimized.

Copy link
@poire-z

poire-z Nov 2, 2019

Contributor

Would need the word "toggle" or "disable/enable", otherwise one may think it's the checkbox that set the mode.

This comment has been minimized.

Copy link
@pazos

pazos Nov 4, 2019

Author Contributor

+1 to toggle or disable/enable. Feel free to correct and merge when ready 😃

This comment has been minimized.

Copy link
@poire-z

poire-z Nov 4, 2019

Contributor

"Camera key touchscreen toggling", if we want to have the same grammatical construct as the previous "Volume key page turning" ? (Although even for this one, my limited english skills would more easily understand a sentence like "Use/allow volume keys to turn page" - so I'm fine with this PR that uses a sentence.)

This comment has been minimized.

Copy link
@pazos

pazos Nov 5, 2019

Author Contributor

the first one is described as an option, the second as an action. The first sentence is saying "this to use x key to do y action" while the second assumes that "this" is an option and says "use x key to do y action".

I prefeer the second option too (in both cases).

@pazos pazos force-pushed the pazos:ts_toggle branch from 2a4fe4e to e5e2c46 Nov 3, 2019
@poire-z poire-z merged commit f1f75c5 into koreader:master Nov 5, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.