Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize local folder with dropbox #5591

Merged
merged 5 commits into from Nov 18, 2019
Merged

Conversation

@robert00s
Copy link
Contributor

robert00s commented Nov 13, 2019

Option to synchronize files in local koreader folder with folder on Dropbox. All files that aren't on the local disk will be downloaded. Files with different sizes will also be downloaded and overwritten.
The download process can be paused or stopped at any time (similar to downloading images in Wikipedia).

Synchronize and settings are available after long press in dropbox account in Cloud storage.
Limitations: Only one folder (without subfolders) can be synchronize with one folder on local storage.

Close: #4971

@Frenzie Frenzie added this to the 2019.12 milestone Nov 13, 2019
@Frenzie Frenzie added the enhancement label Nov 13, 2019
Copy link
Member

Frenzie left a comment

Wow, that's pretty large! ;-)

frontend/apps/cloudstorage/cloudstorage.lua Outdated Show resolved Hide resolved
frontend/apps/cloudstorage/cloudstorage.lua Outdated Show resolved Hide resolved
frontend/apps/cloudstorage/cloudstorage.lua Outdated Show resolved Hide resolved
end

local response, go_on
local procceded_file = 0

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 13, 2019

Member

Typo for processed?

This comment has been minimized.

Copy link
@robert00s

robert00s Nov 14, 2019

Author Contributor

Yes, thanks :)

robert00s and others added 4 commits Nov 14, 2019
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Nov 18, 2019

No one else commented, so I'll merge this now.

@Frenzie Frenzie merged commit 04741d8 into koreader:master Nov 18, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
if not failed_files then failed_files = 0 end
local text
if downloaded_files == 0 and failed_files == 0 then
text = _("No files to download from dropbox.")

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 18, 2019

Member

Whoops, missed this.

elseif downloaded_files > 0 and failed_files == 0 then
text = T(_("Successfuly downloaded %1 files from Dropbox to local storage."), downloaded_files)
else
text = T(_("Successfuly downloaded %1 files from Dropbox to local storage.\nFailed downloaded %2 files."),

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 18, 2019

Member

And this

buttons = {
{
{
text = _("Choose dropbox folder"),

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 18, 2019

Member

And this :-P

@robert00s robert00s deleted the robert00s:dropbox_sync branch Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.