Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mark as read to end of document action #5596

Merged
merged 3 commits into from Nov 16, 2019

Conversation

@robert00s
Copy link
Contributor

robert00s commented Nov 15, 2019

Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
@robert00s robert00s added this to the 2019.12 milestone Nov 15, 2019
@Frenzie Frenzie added the enhancement label Nov 15, 2019
@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Nov 15, 2019

I think it would make more sense to put Cancel in the bottom left. Since Mark as read feels related to book status, that'd basically be a simple swap around like this:

  • Mark as read/Book status
  • Delete file/Next file
  • Cancel/File browser

Any thoughts @poire-z @NiLuJe ?

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Nov 15, 2019

(sorry for the double post of the next one :)

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Nov 15, 2019

I agree with the layout @Frenzie proposes, seems logical to me too.

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Nov 15, 2019

@robert00s

This comment has been minimized.

Copy link
Contributor Author

robert00s commented Nov 16, 2019

@Frenzie Thanks. It really make more sense.

@Frenzie Frenzie merged commit 679b592 into koreader:master Nov 16, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Nov 16, 2019

Thanks!

@robert00s robert00s deleted the robert00s:end_document_read branch Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.