Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Extract Cyrillic/Russian keyboard #5610

Merged
merged 12 commits into from Nov 18, 2019
Merged

[chore] Extract Cyrillic/Russian keyboard #5610

merged 12 commits into from Nov 18, 2019

Conversation

@Frenzie
Copy link
Member

Frenzie commented Nov 18, 2019

Follow-up to #5583.


This change is Reviewable

Follow-up to #5583.
@Frenzie Frenzie added UX chore labels Nov 18, 2019
@Frenzie Frenzie added this to the 2019.12 milestone Nov 18, 2019
Frenzie added 2 commits Nov 18, 2019
@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Nov 18, 2019

@yparitcher Quick sanity check before I continue?

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Nov 18, 2019

Cross-ref to #2032 for specifics on the Cyrillic/Russian keyboard.

@yparitcher

This comment has been minimized.

Copy link
Contributor

yparitcher commented Nov 18, 2019

@yparitcher Quick sanity check before I continue?

looks good so far.

btw if you only need 4 layers for a specific language you can, see hebrew for example.

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Nov 18, 2019

I haven't looked at them all yet. Portuguese seems to be using all layers fully so it's a bit problematic, but I think it should be covered by my updated English keyboard with swipes/popups.

@yparitcher

This comment has been minimized.

Copy link
Contributor

yparitcher commented Nov 18, 2019

either the english one, or if you want to have a Portuguese specific keyboard, you can move the letters with diacritics from other layers to a popup.

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Nov 18, 2019

I don't know if I want anything at this point. It's not like I've researched stuff like https://en.wikipedia.org/wiki/Portuguese_keyboard_layout yet, nor our own history. ;-) Iirc @robert00s wrote it.

Frenzie added 4 commits Nov 18, 2019
@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Nov 18, 2019

@NiLuJe @poire-z @pazos With the exception of Portuguese, ready for review.

Copy link
Contributor

poire-z left a comment

Looks allright: nothing unbalanced jumps at me :)

{ "", "", "@", "2", },
{ "", "", "#", "3", },
{ "", "", "$", "4", },
{ "", "", "%", "5", },

This comment has been minimized.

Copy link
@poire-z

poire-z Nov 18, 2019

Contributor

Any idea why that one (2nd char among the 4) is highlighted by github diff?
(And actually always one at the same place in the 3 following sections.)

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 18, 2019

Author Member

I double checked the characters and they seem to be exactly the same, so I can only assume it's an obscure GH bug.

Screenshot_20191118_232622

This comment has been minimized.

Copy link
@Frenzie

Frenzie Dec 30, 2019

Author Member

@poire-z I now understand why it is. It relates to why I accidentally deleted a few layers in the Japanese layout. The tenth layout is exactly the same as the second, except on this specific line where it's instead of . But GH (intelligently?) regards this as a change rather than as deleting the third to tenth layout. It probably has something to do with the number of spaces.

Screenshot_2019-12-30_16-26-15

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Nov 18, 2019

I'll merge it so that it makes it into the next nightly together with the keyboard layout selection. I tested all the keyboards and I didn't do anything new/weird, so it should be good. ^_^

@Frenzie Frenzie merged commit 15fe0fe into koreader:master Nov 18, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@Frenzie Frenzie deleted the Frenzie:ru-kb branch Nov 18, 2019
@Frenzie Frenzie mentioned this pull request Nov 19, 2019
@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Nov 19, 2019

The korean keyboard got a large globe key, which make the popup large too:
image

Also, for usability, it would be nice if all the globe keys were at the same position when switching layouts (the hebrew keyboard makes it move position) - possibly by making the space bar larger so the bottom row always take the full width:
[Sym] [Globe] [Optional Aéss] [Variable width space] [0, 1 or 2 punct keys] [Enter]
Sym and Enter always stuck to their sides of screen.

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Nov 19, 2019

You know, I was going to suggest just making the buttons larger to that pt_BR question. ;-) I thought it looked a bit out of place at the regular size but feel free to touch it up slightly.

PS Japanese doesn't have Sym. (But it does have roughly the same location.)

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Nov 19, 2019

Not clear in my post, but I wanted to say I don't like it larger :) I like it at the smaller size it has in the english keyboard.
(I'm not planning on touching the keyboards these busy days :))

Frenzie added a commit that referenced this pull request Dec 3, 2019
Changes in this commit:
- Fix arrays to large (10 elements instead of 8) copied from the old keyboard system.  Issue introduced in #5610 
- Add ё popup.
- Change shift key as per #5659 (for both ro and ru keyboards)
- Translate Russian space and symbol keys.
- Rename Sym key to 123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.