Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] PDF footer margins #5620

Merged
merged 5 commits into from Nov 21, 2019
Merged

[fix] PDF footer margins #5620

merged 5 commits into from Nov 21, 2019

Conversation

@yparitcher
Copy link
Contributor

yparitcher commented Nov 20, 2019

closes #5612

the change in ReaderView:recalculate() causes the viewable page size to be calculated by not including the footer, causing the text not to get cut off.

since the page area was not drawing under the footer ReaderView:drawPageSurround() had to be fixed to draw the margin under the footer so when tapping the footer off the area should be dran the background color.


This change is Reviewable

yparitcher added 5 commits Nov 19, 2019
fix tests
The page is a little smaller so the link moved a little, so the coordinates of the tap had to be adjusted.
@Frenzie Frenzie added the bug label Nov 21, 2019
@Frenzie Frenzie added this to the 2019.12 milestone Nov 21, 2019
Copy link
Member

Frenzie left a comment

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Frenzie Frenzie merged commit 6d3e7fc into koreader:master Nov 21, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
code-review/reviewable 3 files reviewed
Details
Frenzie added a commit that referenced this pull request Dec 8, 2019
closes  #5654

like #5620 but for continuous mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.