Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Switch remaining keyboard icons to glyphs #5639

Merged
merged 5 commits into from Nov 25, 2019
Merged

Conversation

@NiLuJe
Copy link
Member

NiLuJe commented Nov 24, 2019

The only two left were Del/Backspace & Enter.

This also allows one to render a specific key in synthetic bold, in order to do so for those two glyphs.


This change is Reviewable

NiLuJe added 2 commits Nov 24, 2019
(Del/Backspace & Enter).

Also, allow a glyph to be rendered in (fake) bold, and use it for those
two.
@Frenzie Frenzie added this to the 2019.12 milestone Nov 24, 2019
@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

Before:
kb_icon

After:
kb_glyph

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Nov 24, 2019

Thanks, I was just about to ask. ;-)

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

The enter glyph is slightly smaller, hence the "bold" trick to compensate.

FWIW, unbolded:

kb_cr_bis

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

Other candidates for the enter glyph (c.f., #5583 (comment)):

  • The actual Enter glyph, which is unfortunately super-weird in FreeSerif:
    kb_enter

  • CR:
    kb_cr

  • Nerdfont's Enter key:
    kb_nerdf

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

TL;DR: The only other decent one is probably nerdfont's ;).

I wasn't necessarily going to bold the Backspace, but it behaves slightly less worse that way re: A2/ghosting on eInk when you tap it ;).

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

(gnu.org / savannah.org is down, hence the CI failures).

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Nov 24, 2019

Not fond of the bold backspace (our orignal icon looked a bit airy'er and nicer to me, but ok).
Really nothing else for backspace in nerdfont?

(No problem with the bolded or unbolded enter key.)

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

I'll double-check, but, surprisingly, no. There's all the crappy Apple meta keys, but not that one -_-".

In case I don't find anything else, are you okay with that one unbolded?

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

... he said before remembering there was the Material design one.

Which is decidedly NOT airy ;p.

kb_mdi

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

The current MDI set does include an outline variant, though (c.f., https://github.com/Templarian/MaterialDesign/blob/master/svg/backspace-outline.svg), so I may be able to finagle something if that one's more amenable ;).

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Nov 24, 2019

In case I don't find anything else, are you okay with that one unbolded?

I'll be ok :) Unbolded prefered, but hava a go with bold it it avoids that ghosting issue.

Which is decidedly NOT airy ;p.

Yep, quite too solid black (it looks like that battery icon knocked down! :)

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Nov 24, 2019

Okay, that looks better with the outline variant ;). (EDIT: Now vertically centered, since it's a custom glyph anyway, let's go crazy xD).

kb_mdi_outline4

(Bonus points for not being completely horrible re: ghosting).

NiLuJe added a commit to NiLuJe/koreader-fonts that referenced this pull request Nov 24, 2019
This time, replace the backspace MDI glyph with the outline variant from
the latest MDI package.

re: koreader/koreader#5639
@NiLuJe NiLuJe mentioned this pull request Nov 24, 2019
@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Nov 24, 2019

Way better ! 👍

NiLuJe added a commit to koreader/koreader-fonts that referenced this pull request Nov 25, 2019
This time, replace the backspace MDI glyph with the outline variant from
the latest MDI package.

re: koreader/koreader#5639
Pickup the tweaked nerdfonts for the backspace symbol
@NiLuJe NiLuJe merged commit 4778d3d into koreader:master Nov 25, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
yparitcher added a commit to yparitcher/koreader that referenced this pull request Jan 24, 2020
Frenzie added a commit that referenced this pull request Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.