Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate file size unit #5651

Merged
merged 2 commits into from Nov 28, 2019
Merged

Translate file size unit #5651

merged 2 commits into from Nov 28, 2019

Conversation

@robert00s
Copy link
Contributor

robert00s commented Nov 28, 2019

Close #5649


This change is Reviewable

@robert00s robert00s added this to the 2019.12 milestone Nov 28, 2019
@Frenzie Frenzie added the i18n label Nov 28, 2019
s = string.format("%4.1f MB", size/1024/1024)
elseif size > 1024 then
s = string.format("%4.1f KB", size/1024)
-- @translators This is abbreviation for the gigabyte, a unit of computer memory or data storage capacity.

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 28, 2019

Member
Suggested change
-- @translators This is abbreviation for the gigabyte, a unit of computer memory or data storage capacity.
-- @translators This is an abbreviation of the gigabyte, a unit of computer memory or data storage capacity.

This comment has been minimized.

Copy link
@Frenzie

Frenzie Nov 28, 2019

Member

For is fine though. Just that "an". 👍

@Frenzie Frenzie merged commit e4dd182 into koreader:master Nov 28, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@robert00s robert00s deleted the robert00s:size_unit branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.