Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Simple symbol keyboard layer paging #5659

Merged
merged 1 commit into from Dec 13, 2019
Merged

Conversation

@Frenzie
Copy link
Member

Frenzie commented Nov 30, 2019

Here's a quick concept for consideration. Use 1/2 and 2/2 instead of Shift.

Screenshot_2019-11-30_16-01-28
Screenshot_2019-11-30_16-01-35


This change is Reviewable

Use 1/2 and 2/2 instead of Shift.
@Frenzie Frenzie added this to the 2019.12 milestone Nov 30, 2019
@SilverGreen93

This comment has been minimized.

Copy link
Contributor

SilverGreen93 commented Dec 1, 2019

I also renamed the Sym key to 123 in my romanian keyboard, and changed that to an alt key when you are in the second character page (see #5660)
1/2, 2/2 are a welcome additional change.

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Dec 1, 2019

Well, before the highlighting of the Shift key, I would have liked it :)
But with the highlighting, it feels a bit less needed - and having 2/2 highlighted (1/2 is not) feels strange/duplicated...
Also, I feel the Shift symbol less ambiguous. I could expect hitting 1/2 would output 1/2 :) Because the ... just above the 2/2 will output ..., while I could as well expect it will move me to the ...next... layer :)

Anyway, just a thought. Go ahead if you prefer it that way.

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Dec 2, 2019

I'd also tend to prefer a symbol over this, too.

I'm okay with Shift, as it's fairly universal, but we also have access to Apple's Command & Alt/Option glyph which might make more sense than shift in this context (the alt one, especially).

At least for people familiar with Apple layouts ;p.

@SilverGreen93

This comment has been minimized.

Copy link
Contributor

SilverGreen93 commented Dec 2, 2019

The shift symbol here I can say it seems a bit ambiguous. On the main letter keyboard it makes sense, but on the symbols keyboard it should indicate something that "there are more symbols here". I would go with anything else BUT the shift symbol.

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Dec 2, 2019

FWIW, I have no strong opinion on that subject. I'd vaguely prefer a symbol (because I also find that it's enough since the HL tweak), but that's it ;).

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Dec 2, 2019

I think any symbol would be significantly less clear than a simple 1/2 and 2/2. Shift would at least be consistent and therefore better than anything trying to be too clever.

Frenzie added a commit that referenced this pull request Dec 3, 2019
Changes in this commit:
- Fix arrays to large (10 elements instead of 8) copied from the old keyboard system.  Issue introduced in #5610 
- Add ё popup.
- Change shift key as per #5659 (for both ro and ru keyboards)
- Translate Russian space and symbol keys.
- Rename Sym key to 123
@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Dec 13, 2019

I'm still in favor of this proposal. Has it grown on you guys by any chance @poire-z @NiLuJe? ;-)

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Dec 13, 2019

Well, I didn't give it a chance to grow on me :) but as I get now that it applies only on the symbol/number layers, it's less drastic that I initially thought. So go ahead.

@Frenzie Frenzie added the UX label Dec 13, 2019
@Frenzie Frenzie merged commit 7d231ac into koreader:master Dec 13, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@Frenzie Frenzie deleted the Frenzie:sym-layer branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.