Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: unbreak KO on scoped storage devices #5680

Merged
merged 2 commits into from Dec 12, 2019

Conversation

@pazos
Copy link
Contributor

pazos commented Dec 10, 2019

Requires koreader/android-luajit-launcher#201

Tested against the Android 10 - emulator

Build with targetApi 28: normal storage, RW path retrieved: /storage/emulated/0
Build with targetApi 29: scoped storage, RW path retrieved: /storage/emulated/0/Android/data/org.koreader.launcher/files

This isn't intended as a long term solution but as a workaround. Lets see what other reading software do to avoid scoped storage limitations.


This change is Reviewable

@pazos

This comment has been minimized.

Copy link
Contributor Author

pazos commented Dec 12, 2019

The bumped launcher module adds a couple of new nooks as known eink devices too.

@pazos pazos merged commit c6f553a into koreader:master Dec 12, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@Frenzie Frenzie added this to the 2019.12 milestone Dec 12, 2019
@Frenzie Frenzie added the Android label Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.