Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we flush everything to disk after an update. #5685

Merged
merged 1 commit into from Dec 16, 2019
Merged

Conversation

@NiLuJe
Copy link
Member

NiLuJe commented Dec 12, 2019

Will stall for longer, but with a visible message (vs. less stalling on
a white screen during the startup and a laggy FM for a while).


This change is Reviewable

WIll stall for longer, but with a visible message (vs. less stalling on
a white screen during the startup and a laggy FM for a while).
@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Dec 12, 2019

Only done one devices where we have visual feedback during an OTA, otherwise it's a random weird stall with no visible warning ;).

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Dec 16, 2019

Let's see how annoying this is in practice ;).

@NiLuJe NiLuJe merged commit 70b2564 into koreader:master Dec 16, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@ptrm

This comment has been minimized.

Copy link

ptrm commented Dec 17, 2019

wow, so this lack of sync might explain why I had most of koreader files 0b in size when hard rebooting just after an upgrade :D

Just wonder if not forcing sync would work in a way of creating empty files and writing the contents later on sync, or would there be no files at all.

@Frenzie Frenzie added this to the 2019.12 milestone Dec 17, 2019
@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Dec 17, 2019

That's probably entering the territory of "undefined behavior", so, who knows ^^. Nothing good, for sure ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.