Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Romanian plural forms #5692

Merged
merged 8 commits into from Dec 16, 2019
Merged

Fix Romanian plural forms #5692

merged 8 commits into from Dec 16, 2019

Conversation

@SilverGreen93
Copy link
Contributor

SilverGreen93 commented Dec 16, 2019

Hardcode the plural forms logic for Romanian.

This fixes #5661 and enables Romanian (Moldova) language in the menu.


This change is Reviewable

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Dec 16, 2019

Thanks, saves me a minute. ;-)

@Frenzie Frenzie added this to the 2019.12 milestone Dec 16, 2019
@Frenzie Frenzie added the i18n label Dec 16, 2019
@Frenzie Frenzie merged commit 739a300 into koreader:master Dec 16, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Dec 16, 2019

Btw, I don't know for sure atm but it's possible that this workaround would be made obsolete by #3754.

@SilverGreen93 SilverGreen93 deleted the SilverGreen93:ro_lang_plural branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.