Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style tweaks: enable EPUB/FB2 in-page footnotes by default #5908

Merged
merged 1 commit into from Feb 28, 2020

Conversation

@poire-z
Copy link
Contributor

poire-z commented Feb 28, 2020

Set these 2 tweaks as default global tweaks for new users (and existing users that have not set any global defaults).
One can disable them by long-press on each of them.
Only per-specs EPUB and FB2 footnotes (other in-page footnotes tweaks may trigger on non-footnote content on some books, so let enabling them be a user decision).
Discussed at #5015 (comment)

So, (mostly) everybody will get:

image

image


This change is Reviewable

Set these 2 tweaks as default global tweaks for new users
(and existing users that have not set any global defaults).
One can disable them by long-press on each of them.
Only per-specs EPUB and FB2 footnotes (other in-page footnotes
tweaks may trigger on non-footnote content on some books, so
let enabling them be a user decision).
@Frenzie Frenzie added this to the 2020.03 milestone Feb 28, 2020
@poire-z poire-z merged commit 72f2cef into koreader:master Feb 28, 2020
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@poire-z poire-z deleted the poire-z:style_tweak_global_default branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.