ReaderFooter: Make pages_left_book use an actual prefix icon #7807
Conversation
Instead of baking in a hyphen, so as to avoid signed zeroes, or confusion with page progress if page maps are enabled. Also, made compact itemps RTL friendly.
NiLuJe
changed the title
|
Not necessarily super-fond of the arrow choice here (other than the semantic hint as a trail arrow), but I don't personally use this widget, so, open to suggestions ;).
|
|
Not using it, but looks ok. |
I can see it in the 'Files changed' tab, FWIW. But GH's home page has been doing wonky shit for a couple days on my end now, so, who knows ^^. |
|
OK, now I have the "Review changes" button... So, nevermind... |
(i.e., in-chapter num / total). Fix koreader#7792
|
Also added the FR from #7792. Ping @Jellby because I don't have anything w/ hidden flows on hand right now to test that I didn't botch (Also, mildly intrigued that we didn't have such a method to begin with?). Also, unsure how well the (existing) hidden flows stuff handles being the first/last chapter, because, AFAICT, |
| current = footer.pageno | ||
| end | ||
| local total = footer.ui.toc:getChapterPageCount(footer.pageno) or footer.pages | ||
| return current .. " ⁄⁄ " .. total |
There was a problem hiding this comment.
Dunno how confusing this can be, but // is already used in page_progress when hasHiddenFlows().
There was a problem hiding this comment.
That's not exactly the same slash, I don't remember which one I settled on, but basically this one has extreme kerning, so you end up with the two being very close together (the idea being it echoes the double arrow of the "remaining pages in chapter" widget ;)).
(In fact, I had to use narrow nbsp around it for the menu entry, otherwise it ran into the parens ;p).
There was a problem hiding this comment.
I'd be happy with changing the // with hidden flows to something else. Maybe ⌿?
There was a problem hiding this comment.
Right now, I'm using the third set (the two narrow slashes very close together). I was thinking of adding a hair space between them: that's the first set (but looking at all of 'em like that, I kinda prefer the current approach, as it's really distinctive).
For comparison, a standard double slash is on second place, and finally the ⌿.
I feel like it's different enough that we can keep the "double means chapter/flow" semantic hint between 'em (so, not touching the flows' double slash).
|
@poire-z You might need to do Ctrl+F5 or something if GH messed up their script cache. |
Frenzie
changed the title
|
Seems that enabling |
|
The wrong total number of pages I see in the Go to dialog as well (in the hint). |
|
The issue is in getPageCount returns previous number of pages (before changing the font size, in my example).
Or is called before the page/footer is recalculated. |
Instead of baking in a hyphen, so as to avoid signed zeroes, or confusion with page progress if page maps are enabled.
Also, made compact items RTL friendly.
This change is
The text was updated successfully, but these errors were encountered: