Wallabag : adds an option to send the review as tags on wallabag#8637
Merged
Frenzie merged 2 commits intokoreader:masterfrom Jan 10, 2022
Merged
Wallabag : adds an option to send the review as tags on wallabag#8637Frenzie merged 2 commits intokoreader:masterfrom
Frenzie merged 2 commits intokoreader:masterfrom
Conversation
Frenzie
reviewed
Jan 9, 2022
Member
Frenzie
left a comment
Frenzie
left a comment
There was a problem hiding this comment.
Btw, if you rebase on top of master the CI will run instead of showing unauthorized. Looks great though, I doubt luacheck will have any complaints. ^_^
agallou
force-pushed
the
wallabag_tags
branch
from
2cc0bde to
6f56754
Compare
Contributor
Author
|
@Frenzie thanks, I've just added your help text and rebased the branch. |
Frenzie
reviewed
Jan 10, 2022
Member
|
Thanks! |
agallou
added a commit
to agallou/koreader
that referenced
this pull request
Jan 26, 2022
In this PR koreader#8637 It worked on my sev environnement, but when updating my device, there were synchronization errors. Apparently sometimes documents do not have a summary. To avoid an error during the synchronisation this change adds checks when getting tags for the document.
agallou
added a commit
to agallou/koreader
that referenced
this pull request
Jan 27, 2022
In this PR koreader#8637 It worked on my sev environnement, but when updating my device, there were synchronization errors. Apparently sometimes documents do not have a summary. To avoid an error during the synchronisation this change adds checks when getting tags for the document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow koreader users to choose to add tags in the review field (separated by comas), and then send them to wallbag.
It adds and option for that (a checkbox) in the wallabag plugin options.
It could be useful to directly tag articles on koreader to find them easily later.
This change is