Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallabag : adds an option to send the review as tags on wallabag #8637

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

agallou
Copy link
Contributor

@agallou agallou commented Jan 9, 2022

This will allow koreader users to choose to add tags in the review field (separated by comas), and then send them to wallbag.
It adds and option for that (a checkbox) in the wallabag plugin options.
It could be useful to directly tag articles on koreader to find them easily later.


This change is Reviewable

@Frenzie Frenzie added the Plugin label Jan 9, 2022
@Frenzie Frenzie added this to the 2022.01 milestone Jan 9, 2022
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, if you rebase on top of master the CI will run instead of showing unauthorized. Looks great though, I doubt luacheck will have any complaints. ^_^

plugins/wallabag.koplugin/main.lua Show resolved Hide resolved
@agallou
Copy link
Contributor Author

agallou commented Jan 10, 2022

@Frenzie thanks, I've just added your help text and rebased the branch.

@Frenzie Frenzie merged commit 1d40949 into koreader:master Jan 10, 2022
@Frenzie
Copy link
Member

Frenzie commented Jan 10, 2022

Thanks!

agallou added a commit to agallou/koreader that referenced this pull request Jan 26, 2022
In this PR koreader#8637
It worked on my sev environnement, but when updating my device, there
were synchronization errors.

Apparently sometimes documents do not have a summary.
To avoid an error during the synchronisation this change adds checks
when getting tags for the document.
agallou added a commit to agallou/koreader that referenced this pull request Jan 27, 2022
In this PR koreader#8637
It worked on my sev environnement, but when updating my device, there
were synchronization errors.

Apparently sometimes documents do not have a summary.
To avoid an error during the synchronisation this change adds checks
when getting tags for the document.
Frenzie pushed a commit that referenced this pull request Jan 27, 2022
#8733)

In this PR #8637
It worked on my sev environnement, but when updating my device, there
were synchronization errors.

Apparently sometimes documents do not have a summary.
To avoid an error during the synchronisation this change adds checks
when getting tags for the document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants