Highlights share

[uroybd]

This PR enables users to share exported highlights on Android.

---

This change is 

[pazos]

@uroybd: made a few changes.

Mostly:

• don't mix logic. Use canShareText as a precondition for doShareText. Avoid specific android checks.
• disabled share submenu if there's no document opened (like the export one).

[uroybd]

@uroybd: made a few changes.

Mostly:

• don't mix logic. Use canShareText as a precondition for doShareText. Avoid specific android checks.
• disabled share submenu if there's no document opened (like the export one).

It looks much cleaner now. I've also made the changes you've asked.

Should I add the same functionality for text, JSON, and html?

[uroybd]

@pazos

Also, I need some help from luajit part.

The doShareText function can do with two modifications:

1. Optional EXTRA_TITLE field. Some apps might use it to set the note/file name. We can send a generated title using this.

2. Option to set mimetype, defaults to text/plain.

[pazos]

@pazos

Also, I need some help from luajit part.

The doShareText function can do with two modifications:

1. Optional EXTRA_TITLE field. Some apps might use it to set the note/file name. We can send a generated title using this.
2. Option to set mimetype, defaults to text/plain.

Both are doable but not for this PR.
They will require some familiary with https://github.com/koreader/android-luajit-launcher.

Also the signature of share text is different https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/extensions/ActivityExtensions.kt#L258, because it was designed to deliver text to specific packages using specific actions, so something like that requires a reestructure I'm not willing to do in short run.

[pazos]

Should I add the same functionality for text, JSON, and html?

Sure, go ahead.

Also you can test them on the emulator with

diff --git a/frontend/device/sdl/device.lua b/frontend/device/sdl/device.lua
index cef65e08..8b86498a 100644
--- a/frontend/device/sdl/device.lua
+++ b/frontend/device/sdl/device.lua
@@ -122,6 +122,10 @@ local Emulator = Device:new{
     canPowerOff = yes,
     canReboot = yes,
     canSuspend = yes,
+    canShareText = yes,
+    doShareText = function(self, text)
+        logger.info("sharing text", text)
+    end,
 }

[uroybd]

@pazos

Instead of isDocReady I'm using isUIReady which doesn't check for enabled formats. Enabling formats are required for file generation. However, for one-off sharing by directly selecting a format it is not necessary.

[uroybd]

Removed WIP.

[pazos]

@pazos

Instead of isDocReady I'm using isUIReady which doesn't check for enabled formats. Enabling formats are required for file generation. However, for one-off sharing by directly selecting a format it is not necessary.

Agree on the logic as it is now, not on the names. The new isUIReady is indeed isDocReady and should be called that way. The other thing, until now called isDocReady, can be renamed isReadyToExport or something similar (honoring the name that it used to have before the refactor and giving a proper name of what it does).

[pazos]

Except for renaming a couple of methods and removing the timestamp the rest looks quite good and it is almost ready for prime time :)

👍

[uroybd]

Except for renaming a couple of methods and removing the timestamp the rest looks quite good and it is almost ready for prime time :)

+1

Renaming and other changes based on the review are done. :)

[pazos]

LGTM