add json for all salt modules #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thant was quick, thanks a lot for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies @marek-obuchowicz, I found a bug. The keystore.json file was missing a trailing
}I also created a salt module to get all state/module functions and default args without needing to run anything: saltstack/salt#56685
Using that for the source of state module data allows sourcing all possible state values without worrying about dependencies. So this would eliminate the need to have any dependencies installed, allowing the generator to run against salt's actual .py files.
This PR thus includes the fixed keystore.json as well as the remaining basic state autocompletes.