Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add json for all salt modules #8

Merged
merged 2 commits into from
Apr 18, 2020

Conversation

mchugh19
Copy link
Contributor

Apologies @marek-obuchowicz, I found a bug. The keystore.json file was missing a trailing }

I also created a salt module to get all state/module functions and default args without needing to run anything: saltstack/salt#56685
Using that for the source of state module data allows sourcing all possible state values without worrying about dependencies. So this would eliminate the need to have any dependencies installed, allowing the generator to run against salt's actual .py files.

This PR thus includes the fixed keystore.json as well as the remaining basic state autocompletes.

@marek-obuchowicz marek-obuchowicz changed the base branch from master to develop April 18, 2020 13:34
@marek-obuchowicz marek-obuchowicz merged commit 8ea4cb9 into korekontrol:develop Apr 18, 2020
@marek-obuchowicz
Copy link
Contributor

Thant was quick, thanks a lot for this!
Release should appear in vscode marketplace within next minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants