New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to parse extra parameters to mysql jdbc #374

Open
wants to merge 2 commits into
base: release_0.4.3
from

Conversation

Projects
None yet
4 participants
@mprokopov

mprokopov commented Dec 30, 2016

Allows specify extra parameters for mysql jdbc driver in map under key :extra

example:

(def db-params (mysql {:host "localhost"
                   :db "itservice"
                   :user "root"
                   :extra {:useLegacyDatetimeCode false
                           :serverTimezone "UTC"
                           :useSSL false}}))

this appends "?useLegacyDatetimeCode&serverTimezone=UTC&useSSL=false" to subname

@jiacai2050

This comment has been minimized.

Show comment
Hide comment
@jiacai2050

jiacai2050 Jul 26, 2017

Is there anyone looking into this ?

jiacai2050 commented Jul 26, 2017

Is there anyone looking into this ?

@venantius

This comment has been minimized.

Show comment
Hide comment
@venantius

venantius Feb 27, 2018

Contributor

In general this approach seems fine, but it needs tests before we'll be able to consider merging it.

Contributor

venantius commented Feb 27, 2018

In general this approach seems fine, but it needs tests before we'll be able to consider merging it.

@@ -1,4 +1,4 @@
(defproject korma "0.4.3"

This comment has been minimized.

@venantius

venantius Feb 27, 2018

Contributor

Don't change the project name.

@venantius

venantius Feb 27, 2018

Contributor

Don't change the project name.

@zjjfly

This comment has been minimized.

Show comment
Hide comment
@zjjfly

zjjfly Jun 1, 2018

though we can specify extra parameters in :db,this pr offers much better clearity

zjjfly commented Jun 1, 2018

though we can specify extra parameters in :db,this pr offers much better clearity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment