Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for fuzzing #29
Conversation
Shnatsel
added some commits
Jun 20, 2018
kornelski
merged commit 1852515
into
kornelski:master
Jun 28, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thank you. |
This comment has been minimized.
This comment has been minimized.
|
The fix for it was trivial — deletion of one line: 37a7bcc And the leak existed there only because this crate keeps ABI compatibility with its C version, so it has to |
This comment has been minimized.
This comment has been minimized.
|
I feel C ABI compatibility is a major selling point of this crate compared to something Rust-only, such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Shnatsel commentedJun 28, 2018
cargo-fuzzthat was used to discover #28If you do not wish to have "fuzz" folder within the project, I can put it in https://github.com/rust-fuzz/targets repository instead.