From b13d21c0283545b4fa0b45cbd11af1400f596fb1 Mon Sep 17 00:00:00 2001 From: Greg S Date: Mon, 1 Jan 2018 03:37:15 +0100 Subject: [PATCH 1/5] remove php7.1 min version to allow php 5.5 and 5.6 --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 7536343..c3a6da6 100644 --- a/composer.json +++ b/composer.json @@ -10,7 +10,7 @@ } ], "require": { - "php": ">=7.1.0" + "php": ">=5.5.9" }, "autoload": { "psr-4": { From a3d75c348fbe470ba2466003f31ebb24047be7f4 Mon Sep 17 00:00:00 2001 From: Greg S Date: Mon, 1 Jan 2018 04:31:00 +0100 Subject: [PATCH 2/5] add php5 platforms for travis --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 682bc61..42d3431 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,8 @@ language: php php: + - 5.5 + - 5.6 - 7.1 - 7.2 - nightly From 37eba6dd99d8dd47bfdfb5be20845b0fd93eb8ec Mon Sep 17 00:00:00 2001 From: Greg S Date: Mon, 1 Jan 2018 04:37:28 +0100 Subject: [PATCH 3/5] mention smaller phpunit version for compatibility --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index c3a6da6..ac11375 100644 --- a/composer.json +++ b/composer.json @@ -18,7 +18,7 @@ } }, "require-dev": { - "phpunit/phpunit": "^6.5", + "phpunit/phpunit": "4.8.36|^6.5", "satooshi/php-coveralls": "~2" } } From 6de63a27d0745621a2dd7b32403b2d274331f31d Mon Sep 17 00:00:00 2001 From: Greg S Date: Mon, 1 Jan 2018 04:51:14 +0100 Subject: [PATCH 4/5] remove php5 incompatible code --- composer.json | 2 +- src/Keccak.php | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/composer.json b/composer.json index ac11375..00c36a4 100644 --- a/composer.json +++ b/composer.json @@ -18,7 +18,7 @@ } }, "require-dev": { - "phpunit/phpunit": "4.8.36|^6.5", + "phpunit/phpunit": "4.8.36|6.5", "satooshi/php-coveralls": "~2" } } diff --git a/src/Keccak.php b/src/Keccak.php index c5ad2e8..76b80f5 100644 --- a/src/Keccak.php +++ b/src/Keccak.php @@ -3,14 +3,12 @@ namespace kornrunner; use Exception; -use function mb_strlen; -use function mb_substr; final class Keccak { - private const KECCAK_ROUNDS = 24; - private const LFSR = 0x01; - private const ENCODING = '8bit'; + const KECCAK_ROUNDS = 24; + const LFSR = 0x01; + const ENCODING = '8bit'; private static $keccakf_rotc = [1, 3, 6, 10, 15, 21, 28, 36, 45, 55, 2, 14, 27, 41, 56, 8, 25, 43, 62, 18, 39, 61, 20, 44]; private static $keccakf_piln = [10, 7, 11, 17, 18, 3, 5, 16, 8, 21, 24, 4, 15, 23, 19, 13, 12,2, 20, 14, 22, 9, 6, 1]; private static $x64 = (PHP_INT_SIZE === 8); From 2285404015a6bedf1085748662be31e273bc3ae4 Mon Sep 17 00:00:00 2001 From: Greg S Date: Mon, 1 Jan 2018 05:03:50 +0100 Subject: [PATCH 5/5] allow failures for PHP5.5-5.6 - uninstallable dependencies --- .travis.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.travis.yml b/.travis.yml index 42d3431..a2cd8a4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,6 +7,12 @@ php: - 7.2 - nightly +matrix: + fast_finish: true + allow_failures: + - php: 5.5 + - php: 5.6 + install: - if [[ "$TRAVIS_PHP_VERSION" != "nightly" ]]; then phpenv config-rm xdebug.ini; fi - travis_retry composer self-update