Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update functions.sh #7

Merged
merged 1 commit into from Oct 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

darKpoiSon commented Oct 6, 2012

stopping and restarting the adb server to ensure it runs as root and the devices are shown

Update functions.sh
stopping and restarting the adb server to ensure it runs as root and the devices are shown
Owner

kosborn commented Oct 6, 2012

Looks good for the most part. In my experience, though, 'su' on its own drops you into a root shell, doesn't elevate privs. Might I suggest su -c 'adb start-server'? Should start the server as root, and fork. Either way, I'll push this in tonight.

kosborn added a commit that referenced this pull request Oct 8, 2012

Merge pull request #7 from darKpoiSon/patch-1
Update functions.sh to include killing of adb server before restarting it as root.

@kosborn kosborn merged commit cd4c906 into kosborn:master Oct 8, 2012

Owner

kosborn commented Oct 8, 2012

Pushed a fix to this merge, 4b05e85

Just changed invocation of su to su -c 'commands' and dropped the codeblock below where testing that adb is in $PATH.

This should resolve issue #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment