-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Custom pre-commit hook #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, rest of it looks decent enough. It will get the job done.
If you somehow want it to be more robust then add checks whether those commands ran properly or not and print corresponding messages
change the &> redirection Co-authored-by: Arpit Bhardwaj <proffapt@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@proffapt merge if the shell script is fine.
Ahhh, my base standard for shell scripts is a bit high, not fine but will get the job done so fine.. idk |
Added a custom pre-commit hook for linting commits, along with a shell script to install the hook.
Chose to do this over using the pre-commit tool because dependencies and runtime environments for all the hooks needed were externally managed anyway. This way, fewer things to look for if something breaks.