Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a DEV environment variable to use local .db file #98

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

harshkhandeparkar
Copy link
Member

Changes

  • Added an environment DEV (boolean). Setting this variable to true will use a local devDB.db sqlite3 database file instead of the online Postgres db.
  • Refactored InitialMigration() to use the GetDB() method (removed duplicated code)
  • Added a defer db.Close() to IntialMigration()

@rajivharlalka
Copy link
Member

Rest Looks fine, but iirc there were issues wrt to automigrations of table schema. Not something to look into now, but ig we can refactor the schema this year? and handle dashboards better way, showing graph and stuff. people like it nowadays? Can you create an issue with this respect.

@harshkhandeparkar
Copy link
Member Author

Rest Looks fine, but iirc there were issues wrt to automigrations of table schema. Not something to look into now, but ig we can refactor the schema this year? and handle dashboards better way, showing graph and stuff. people like it nowadays? Can you create an issue with this respect.

Both things on my TODO, will open issues soon.

@rajivharlalka
Copy link
Member

LGTM, Merging

@rajivharlalka rajivharlalka merged commit 417eb55 into master Jun 9, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the dev-env-var branch June 9, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants