This repository has been archived by the owner. It is now read-only.

jquery.turbolinks does not work with Foundation 2.x #4

Closed
Flink opened this Issue Oct 15, 2012 · 15 comments

Comments

Projects
None yet
3 participants

Flink commented Oct 15, 2012

I have a rails project using zurb foundation 2.x. I just tried your gem hoping that all will be working as foundation uses $.ready() function. But instead it breaks on the customforms plugin:

TypeError: $ is undefined
$.foundation.customForms.appendCustomMarkup = function () 

So is it a problem with jquery.turbolinks or zurb foundation?

Owner

kossnocorp commented Oct 15, 2012

Without jquery.turbolinks all works in normal way?

Flink commented Oct 15, 2012

Yes, except for bindings to $.ready() of course :) But there is no error when loading foundation without jquery.turbolinks.

Owner

kossnocorp commented Oct 15, 2012

Can you show me your manifest file?

Flink commented Oct 15, 2012

Here it is:

//= require jquery
//= require turbolinks
//= require jquery.turbolinks
//= require foundation
//= require jquery_ujs
//= require jquery.ui.core
//= require jquery.ui.widget
//= require jquery.ui.autocomplete
//= require rails-timeago
//= require formatcurrency
//= require_tree ./frontend
Owner

kossnocorp commented Oct 15, 2012

Thanks! I'm going to create test application and debug this issue. Give me 30 minutes :-).

Owner

kossnocorp commented Oct 15, 2012

Got it! Thanks. New version will be ready soon.

Flink commented Oct 15, 2012

Great! Thanks :)

Owner

kossnocorp commented Oct 15, 2012

Done. Please update jquery-turbolinks to v0.2.1: https://rubygems.org/gems/jquery-turbolinks/versions/0.2.1

Owner

kossnocorp commented Oct 15, 2012

Now everything is ok?

@kossnocorp kossnocorp referenced this issue in turbolinks/turbolinks-classic Oct 15, 2012

Closed

Import code from jquery.turbolinks #86

Flink commented Oct 16, 2012

Yes everything’s ok with foundation now, thanks a lot! :)

Owner

kossnocorp commented Oct 16, 2012

Good.

Owner

kossnocorp commented Oct 25, 2012

not working for me... When i follow a link it breaks the foundationNavigation (as an example). Please let me know if you did anything special to get this to work. Thanks

@Flink can you describe how it breaks? I'm not sure I clearly understand problem.

@kossnocorp kossnocorp reopened this Oct 25, 2012

elfassy commented Oct 25, 2012

@kossnocorp I posted that message and then deleted it. It was not an issue with jquery.turbolinks but with my setup. In fact i can validate that jquery.turbolinks works great! Thanks

Flink commented Oct 25, 2012

@kossnocorp Seems you can re-close the issue ;)

Owner

kossnocorp commented Oct 25, 2012

@elfassy thank you!

@kossnocorp kossnocorp closed this Oct 25, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.