New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth2 support, update api methods, improve README, JSON related bugfix #1

Merged
merged 6 commits into from Jun 28, 2013

Conversation

Projects
None yet
2 participants
@theosp
Contributor

theosp commented Jun 25, 2013

  • Add oauth2 support with examples and README usage documentation.
  • Add a new api method: discussions.get_list.
  • Improve README.
  • Bugfix: api_methods: JSON parsing should be done with the quirks_mode option set to true.

You've done a very nice job laying the foundation for this gem, it was a pleasure to extend it and improve it.

Daniel Chcouri

@kostyantyn

This comment has been minimized.

Show comment
Hide comment
@kostyantyn

kostyantyn Jun 26, 2013

Owner

Thank you for your pull request. Nice job!

Please, indent your code with two spaces and i'll merge it into the master and release a new version of the gem.

Owner

kostyantyn commented Jun 26, 2013

Thank you for your pull request. Nice job!

Please, indent your code with two spaces and i'll merge it into the master and release a new version of the gem.

@theosp

This comment has been minimized.

Show comment
Hide comment
@theosp

theosp Jun 27, 2013

Contributor

Done.

Contributor

theosp commented Jun 27, 2013

Done.

kostyantyn added a commit that referenced this pull request Jun 28, 2013

Merge pull request #1 from theosp/add_oauth2_support
Add oauth2 support, update api methods, improve README, JSON related bugfix

@kostyantyn kostyantyn merged commit b3cbabb into kostyantyn:master Jun 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment