New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repetitive crash of the editor for when randomly clicking on entities on scene #104

Closed
omomthings opened this Issue Dec 22, 2015 · 10 comments

Comments

Projects
None yet
2 participants
@omomthings

omomthings commented Dec 22, 2015

Working on a brand new scene the editor crashes randomly for no appearing reason, I juste click on another element on scene to un-select the selected one and sometimes the editor crashes, with that i lost all what I didnt save, made me think of an auto save backup maybe good while the editor is not stable enough.. here is a bunch of crash log for the same reason, the same manipulation.
viseditor-crash 15-12-22 17-09-17.txt
viseditor-crash 15-12-22 17-38-44.txt
viseditor-crash 15-12-22 17-43-20.txt
viseditor-crash 15-12-22 17-52-20.txt

kotcrab added a commit that referenced this issue Dec 22, 2015

kotcrab added a commit that referenced this issue Dec 22, 2015

@kotcrab

This comment has been minimized.

Show comment
Hide comment
@kotcrab

kotcrab Dec 22, 2015

Owner

I have found and fixed two issues, crashes when using RotateTool and exporting scene which used string group ids. I'm not sure about this:

java.lang.IllegalStateException: EntitiesCollector didn't find any matching entity
    at com.kotcrab.vis.editor.module.scene.system.EntitiesCollector.createSelectionFragment(EntitiesCollector.java:70)
    at com.kotcrab.vis.editor.module.scene.entitymanipulator.EntitiesSelection.append(EntitiesSelection.java:99)
    at com.kotcrab.vis.editor.module.scene.entitymanipulator.EntityManipulatorModule.selectAppend(EntityManipulatorModule.java:619)

May be fixed but I need to test more, If it happens again, please post more logs. It is definitely related to groups.

with that i lost all what I didnt save, made me think of an auto save backup maybe good while the editor is not stable enough

See #105

Owner

kotcrab commented Dec 22, 2015

I have found and fixed two issues, crashes when using RotateTool and exporting scene which used string group ids. I'm not sure about this:

java.lang.IllegalStateException: EntitiesCollector didn't find any matching entity
    at com.kotcrab.vis.editor.module.scene.system.EntitiesCollector.createSelectionFragment(EntitiesCollector.java:70)
    at com.kotcrab.vis.editor.module.scene.entitymanipulator.EntitiesSelection.append(EntitiesSelection.java:99)
    at com.kotcrab.vis.editor.module.scene.entitymanipulator.EntityManipulatorModule.selectAppend(EntityManipulatorModule.java:619)

May be fixed but I need to test more, If it happens again, please post more logs. It is definitely related to groups.

with that i lost all what I didnt save, made me think of an auto save backup maybe good while the editor is not stable enough

See #105

@omomthings

This comment has been minimized.

Show comment
Hide comment
@omomthings

omomthings Dec 22, 2015

groups? i wonder how it can be related to groups since I didn't have any entity group in my scene! I have different layers but I definitely don't have any group.. when you release a build with those fix's i'll try again and keep you informed!

omomthings commented Dec 22, 2015

groups? i wonder how it can be related to groups since I didn't have any entity group in my scene! I have different layers but I definitely don't have any group.. when you release a build with those fix's i'll try again and keep you informed!

@kotcrab

This comment has been minimized.

Show comment
Hide comment
@kotcrab

kotcrab Dec 22, 2015

Owner

Ow, actually, it may be related to layers. Snapshot build is already available.

Owner

kotcrab commented Dec 22, 2015

Ow, actually, it may be related to layers. Snapshot build is already available.

@omomthings

This comment has been minimized.

Show comment
Hide comment
@omomthings

omomthings Dec 22, 2015

I have tested the new release, I think that the problem is solved, may need to wait more and test more to be sure... your call

omomthings commented Dec 22, 2015

I have tested the new release, I think that the problem is solved, may need to wait more and test more to be sure... your call

@kotcrab

This comment has been minimized.

Show comment
Hide comment
@kotcrab

kotcrab Dec 22, 2015

Owner

EntitiesCollector didn't find any matching entity still occurs, I'm searching for reliable way to reproduce it.

Owner

kotcrab commented Dec 22, 2015

EntitiesCollector didn't find any matching entity still occurs, I'm searching for reliable way to reproduce it.

@kotcrab kotcrab closed this in 7981255 Dec 22, 2015

@omomthings

This comment has been minimized.

Show comment
Hide comment
@omomthings

omomthings Dec 22, 2015

tried various ways, can't reproduce it, earlier it was caused when i was directly working on the properties of an entity and then selected a different one (from the same layer) but cant reproduce it

omomthings commented Dec 22, 2015

tried various ways, can't reproduce it, earlier it was caused when i was directly working on the properties of an entity and then selected a different one (from the same layer) but cant reproduce it

@kotcrab

This comment has been minimized.

Show comment
Hide comment
@kotcrab

kotcrab Dec 22, 2015

Owner

Alright, I hope it fixed all those issues so I'm closing this. Please reopen or create new issue if this still occurs.

Owner

kotcrab commented Dec 22, 2015

Alright, I hope it fixed all those issues so I'm closing this. Please reopen or create new issue if this still occurs.

@omomthings

This comment has been minimized.

Show comment
Hide comment
@omomthings

omomthings Dec 22, 2015

ok of course ! :)

omomthings commented Dec 22, 2015

ok of course ! :)

@omomthings

This comment has been minimized.

Show comment
Hide comment
@omomthings

omomthings Dec 22, 2015

@kotcrab you changed something in the output scene, now the scene files don't work anymore on runtime, in the scene file here is the difference with a previous working version of the same file
actual file: groupIds:{}
working version: groupsIds:{size:0,entries:[]}
I dont think that it would need to be declared as a new issue since it is a result of a minor modification..

omomthings commented Dec 22, 2015

@kotcrab you changed something in the output scene, now the scene files don't work anymore on runtime, in the scene file here is the difference with a previous working version of the same file
actual file: groupIds:{}
working version: groupsIds:{size:0,entries:[]}
I dont think that it would need to be declared as a new issue since it is a result of a minor modification..

@kotcrab

This comment has been minimized.

Show comment
Hide comment
@kotcrab

kotcrab Dec 22, 2015

Owner

Yes, it was necessary to fix one of the issues. You will need to reexport your scenes and use runtime 0.3.1-SNAPSHOT.

Owner

kotcrab commented Dec 22, 2015

Yes, it was necessary to fix one of the issues. You will need to reexport your scenes and use runtime 0.3.1-SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment