Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisValidatableTextField should report as valid when disabled #163

Closed
czyzby opened this issue Apr 20, 2016 · 1 comment
Closed

VisValidatableTextField should report as valid when disabled #163

czyzby opened this issue Apr 20, 2016 · 1 comment
Labels

Comments

@czyzby
Copy link
Contributor

@czyzby czyzby commented Apr 20, 2016

When a user is asked to fill a form, he should be "punished" for being unable to modify disabled widgets. Disabled check boxes or text fields can be used in forms to show default settings (or settings editable only under certain conditions) - in such case, the application creator should make sure that the data is valid, and field validation should be turned off, as the user has no way to change the data.

Current implementation ignores the disabled status - a form with disabled, unfillable fields still reports as full of errors, even though the user is pretty much stuck in such situation.

@kotcrab
Copy link
Owner

@kotcrab kotcrab commented Apr 21, 2016

I've implemented this at FormValidator level and made it the default behavior. Plus I've changed VisCheckBox and VisTextFiled to now draw error border when they are disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.