Add jsoup matchers

[faogustavo]

skrape{it} is a Kotlin-based HTML/XML testing and web scraping library that can be used seamlessly in Spring-Boot, Ktor, Android or other Kotlin-JVM projects.

They want to add a lot of matchers and support the KotlinTest library (You can see all the expected matchers in this issue). If you are comfortable with this, I can implement those matchers myself.

Most of them, are matchers from jsoup library and can be added to the project as an extension and be used by other projects, beside the skrape{it}.

[LeoColman]

Sure, go ahead!
I believe we can add an assertions module for skrape.it.

The mantainers of the project already said that support can be mantained here (just like we do for Arrow and KTor).

I don't see a reason why not.

[LeoColman]

If you need any help configuring the new module, let me know

[faogustavo]

Alright. Thanks @Kerooker

[sksamuel]

I think kotest-assertions-skrape would be a good addition.

[faogustavo]

@sksamuel as the lib just wants to add some assertations to jsoup classes, isn't it better to add a kotest-assertations-jsoup?

[sksamuel]

Yes sorry.

[LeoColman]

Oh, I didn't see that. I thought the matchers were for the lib itself. Guess I didn't read it properly =S

[sksamuel]

We could do both, no reason the jsoup specific ones should live in a skrapeit module.

…

On Wed, 2 Oct 2019 at 04:58, Christian Dräger ***@***.***> wrote: i think it would be cool to go for kotest-assertations-skrapeit because we would have the freedom to add specific assertion on skrape{it}'s Result object <https://github.com/skrapeit/skrape.it/blob/master/src/main/kotlin/it/skrape/core/Result.kt> (beside the document) in the future. in this case i mean assertions regarding the http response (status code, content-type, headers etc) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1028>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGV7R7BFFVQBMND54P3QMRWCPANCNFSM4I4NWT2Q> .

[faogustavo]

Yeps, my plan is to start with the JSOUP assertations that are more generic and than add some others that are specific from the skrape.it;

I already started the JSOUP and hope to open a PR with some basic matchers soon.

[faogustavo]

Hey guys.
Unfortunately, I'm a little bit busy these days and will not be able to add more matchers to jsoup. I just removed the WIP from the PR to merge the initial structure.
Doing this, it's possible for other developers add more matchers and start using it.

[sksamuel]

Great thanks for the pr!

…

On Tue, 22 Oct 2019, 06:55 Gustavo Fão Valvassori, ***@***.***> wrote: Hey guys. Unfortunately, I'm a little bit busy these days and will not be able to add more matchers to jsoup. I just removed the WIP from the PR to merge the initial structure. Doing this, it's possible for other developers add more matchers and start using it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1028>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFVSGXWYAJZYE7DW7JMEHDQP3S4PANCNFSM4I4NWT2Q> .