Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolation instead of isolationMode #1418

Closed
LeoColman opened this issue Apr 27, 2020 · 0 comments · Fixed by #1437
Closed

isolation instead of isolationMode #1418

LeoColman opened this issue Apr 27, 2020 · 0 comments · Fixed by #1437
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.

Comments

@LeoColman
Copy link
Member

When configuring tests using the inline features, isolation is a parameter, however intuition would suggest that isolationMode = IsolationMode.InstancePerTest is expected.

The old isolation parameter should be deprecated in favor of isolationMode

@LeoColman LeoColman added enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project. labels Apr 27, 2020
@LeoColman LeoColman reopened this May 11, 2020
LeoColman added a commit that referenced this issue May 11, 2020
With this commit, I've deprecated the `isolation` spec variable, in favour of a variable that's closer to the `isolationMode()` function.

Closes #1418
LeoColman added a commit that referenced this issue May 11, 2020
With this commit, I've deprecated the `isolation` spec variable, in favour of a variable that's closer to the `isolationMode()` function.

Closes #1418
@sksamuel sksamuel mentioned this issue Jun 7, 2020
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants